rust-lang / rust-lang/rust-clippy
lint useless numeric cast on the rhs of a bitshift
Open
Nobody has claimed this yet.
A-lint
E-medium
L-unnecessary
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
The rhs of a bitshift can be any numeric type. So we should lint on casting a signed int to a signed int, or an unsigned int to an unsigned int, or an unsigned int to a bigger signed int.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by locating Clippy's handling and tests for bitshift expressions, then compare the right-hand-side numeric type combinations described in the issue. Done means the specified signed and unsigned casts are linted without flagging other valid numeric types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100