rust-lang / rust-lang/rust-clippy
lint overbroad lock scopes
Open
Nobody has claimed this yet.
A-lint
E-medium
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
E.g. if at the beginning or the end of a Lock.lock() scope, only local data is accessed, one can reorder the code to make the critical sections smaller (and hopefully improve performance).
This should probably be #[allow] until we have some experience with it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no file, test, or entry point. Start by surveying rust-clippy’s lint registration and existing lock-related tests; done should include a lint for unnecessarily broad Lock.lock() scopes, initially allowed, with tests covering the reported cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100