rust-lang / rust-lang/rust-clippy

lint logically inconsistent checks

Open
#685 5 comments 0 reactions 1 assignee View on GitHub

@ianbollinger is already working on this.

Since Oct 30, 2025.

A-lint E-medium T-middle
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

e.g. x == 10 && x == 0, or checks that can be simplified, e.g. x > 10 && x > 12 (which can be simplified to x > 12). This requires a RangeSet implementation (there is range_map, but it works only for integers and doesn't allow adding a Range, strangely) over constant values, as well as a bit of cleverness to find out if checks are inconsistent or needless.

The idea is to decompose the expression on || / && subexpressions, and check their operands. For example:

  • x > 3 && x < 3 is a falsity
  • x > 3 && x > 5 can be reduced to the latter subexpression because it is fully contained in the former
  • x < 3 || x >= 3 is tautological

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.