rust-lang / rust-lang/rust-clippy
Inconsistent underscores false positive?
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Ok so this is a fun one. cargo fmt doesn't understand astetics of verticals alas ( https://github.com/rust-lang/rustfmt/issues/4710 ), but with the odd trailing _ you can fool cargo fmt into doing the right thing and making things beautiful:
https://github.com/mimblewimble/grin/pull/3572/files
But clippy's not happy with inconsistent underscores. ( https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping )
Is there a better solution than a few trailing underscores? (leading underscores are banned) if not, could clippy not complain about trailing underscores please?
Tables come up a lot in programming so it would be nice to have good ways to format them.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked rustfmt issue, the Grin pull request, and the inconsistent_digit_grouping lint documentation. Reproduce the interaction between cargo fmt and Clippy using the table-formatting example, then determine whether trailing underscores should be accepted or whether another approach is preferred. Done means the false-positive behavior has a documented resolution and corresponding validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100