rust-lang / rust-lang/rust-clippy

Suggest UFCS simplification

Open
#680 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint E-hard L-unnecessary T-middle
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

A case like this: <V as Initializer>::is_fixed_size() may be simplified to: V::is_fixed_size() when it is unambiguous.

Maybe it's hard to figure out when the simple case is unambiguous, I just fixed a couple of the long form (that code dated from before the short form was allowed) and maybe clippy could have suggested it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reported <V as Initializer>::is_fixed_size() example and investigate how Clippy could determine when the shorter V::is_fixed_size() form is unambiguous. No files or tests are named; done means the applicable long forms receive a correct simplification suggestion without changing ambiguous cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.