rust-lang / rust-lang/rust-clippy

Enhancements for `manual_flatten`

Open
#6,676 4 comments 1 reaction 1 assignee View on GitHub

Nobody has claimed this yet.

C-enhancement good first issue L-style
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Enhancements for manual_flatten

  1. for_each

    Before:

    iter.for_each(|o| {
    if let Some(x) = o { //.. }
})

    After

    iter.flatten().for_each(|o| //..)

  2. nested loops

    Before:

    for x in vec![vec![1]] {
    for y in x {
        //..  x is not used again
    }
}

    After:

    for x in vec![vec![1]].into_iter().flatten() {
    // ..
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.