rust-lang / rust-lang/rust-clippy
release tagging: clippy 1.46 tag and rustc 1.46 tag diverge
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Now that clippy is contained inside the rustc repo as a subrepo, how do we do the release tagging?
I noticed that that the 1.46.0 tag inside the clippy repo points to c2c07fa9d095931eb5684a42942a7b573a0c5238
Auto merge of #5740 - lzutao:unused-unused, r=flip1995
Remove unused allowed unused attributes
changelog: none
but when checking out the tag 1.46.0 of the rustc repo and cd-ing into the clippy subrepo, the last commit that touched clippy is 90f1d724c8d9b364b4b0c81817484afa04c73009
Rollup merge of #72920 - oli-obk:const_transmute, r=RalfJung
Stabilize `transmute` in constants and statics but not const fn
cc #53605 (leaving issue open so we can add `transmute` to `const fn` later)
Previous attempt: #64011
In short, the clippy 1.46.0 tag does not represent the rustc 1.46.0 tag. :/
I would expect that if I check out 1.46.0 inside the clippy repo I would get the clippy that was shipped with the rust release.
To make this happen I guess we need to do syncs both way shortly before the release to so that changes that were pushed into rustc are inside clippy and changes from clippy are inside rustc.
Should we redo the 1.46.0 tag inside the clippy repo somehow?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the clippy and rustc 1.46.0 tags and the commits recorded for the clippy subrepo, as described in the issue. Trace the release tagging and synchronization process to determine how both repositories should be aligned; done means checking out either 1.46.0 tag yields the clippy code shipped with that Rust release.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- release
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100