rust-lang / rust-lang/rust-clippy
Lint `unsigned - other_unsigned > 0`
Open
Nobody has claimed this yet.
A-lint
good first issue
L-correctness
S-needs-discussion
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Idea from here.
Basically, x - y, where x and y are of some unsigned integer type, returns 0 iff x == y, so comparing the difference to 0 is dodgy and should at least be rewritten for clarity.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating existing Rust Clippy lint implementations and their tests for unsigned arithmetic comparisons. Confirm the intended behavior for x - y > 0 when both operands are unsigned, then add the lint and coverage showing the diagnostic and its accepted equivalent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100