rust-lang / rust-lang/rust-clippy

git subtree crashes: can't sync rustc clippy changes into rust-lang/rust-clippy

Open
#5,565 24 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-infra
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

The command to sync rustc-changes into the clippy repo
crashes on my and @oli-obk s machine which means we can't sync clippy that way.
$ git subtree push -P src/tools/clippy git@github.com:matthiaskrgr/rust-clippy2 sync-from-rust

git push using:  git@github.com:matthiaskrgr/rust-clippy2 sync-from-rust
/usr/lib/git-core/git-subtree: line 757: 181726 Done                    eval "$grl"
     181727 Segmentation fault      (core dumped) | while read rev parents; do
    process_split_commit "$rev" "$parents" 0;
done

We need to figure out a way to work around that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the documented git subtree push command and inspect git-subtree around line 757, especially the process_split_commit pipeline. Determine a workaround for the segmentation fault and verify that syncing src/tools/clippy into the clippy repository completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
git
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.