rust-lang / rust-lang/rust-clippy

Suggest indexing for `str::char_indices().skip_while(|(i, _)| *i < index)`

Open
#5,485 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint E-medium L-complexity L-suggestion
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

let string = "example:hello";
let index = 5;

let result = string
    .char_indices()
    .skip_while(|(i, _)| *i < index)
    .find_map(|(i, c)| if c == ':' { Some(i) } else { None });

assert_eq!(result, Some(7))

could be optimized to

let string = "example:hello";
let index = 5;

let result = string[index..]
    .char_indices()
    .find_map(|(i, c)| if c == ':' { Some(i) } else { None })
    .map(|i| i + index);

assert_eq!(result, Some(7))

Indexing operations are faster than skipping to a specific index.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Rust examples in the issue and determine how Clippy recognizes the char_indices().skip_while pattern. The work is done when a lint suggests slicing at the byte index and preserves the demonstrated result, with appropriate coverage added in the Clippy test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.