rust-lang / rust-lang/rust-clippy
New lint: let statement with no effect
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
As featured in this Twitter poll.
A statement of the form let _ = <place> has no effect (modulo Deref coersion) as the place is not moved from. This should instead be omited (if all Deref coersion is pure) or otherwise written to be more clear on intent (explicitly calling side-effectful Deref).
50% of people had the wrong intuition of behavior here, so this definitely would help avoid potentially misleading code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named in the issue. Start by locating existing rust-clippy lints for let statements and their tests, then determine how the proposed no-effect behavior should distinguish pure dereference coercions from explicitly side-effectful dereference. Done means the lint behavior and its diagnostic are covered by focused tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100