rust-lang / rust-lang/rust-clippy
New lint for redundant clone in `format!`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
If somebody writes format!("foo: {}", foo.clone()) is that always redundant (since format takes a reference to its arguments and then drops them instantly)? Maybe make sure it doesn't trigger on e.g. foo.clone().bar() since that isn't necessarily redundant.
I feel like this is a specific case of cloning an immutable non-owned type that you don't then retain but that'd require proper compiler support.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by reproducing the format!("foo: {}", foo.clone()) case and compare it with a chained expression such as foo.clone().bar(). Done means establishing whether a Clippy lint can safely identify only redundant clones without requiring unresolved compiler support.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100