rust-lang / rust-lang/rust-clippy

should_implement_trait triggers for next() where the return value has lifetimes

Open
#5,004 5 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-bug
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

This should not trigger the lint until we get generic associated types:

pub fn next(&mut self) -> Option<(&K, &mut V)>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the should_implement_trait lint and reproduce the issue with the Rust snippet in the report. Determine why next() with borrowed return values triggers the lint; done means this signature no longer triggers it before generic associated types are available.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.