rust-lang / rust-lang/rust-clippy

Detect Rust2018-incompatible macros

Open
#4,995 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint E-medium T-macros
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Exported macros that invokes other macros in the same crate without $crate:: prefix should be linted, as that requires users doing use the_crate::{the_macro, the_other_macro} (or #[macro_use] extern) even if the only thing they want to use is the_macro.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Rust 2018 macro changes documentation to understand the required $crate:: behavior. Then locate rust-clippy's lint implementation and test entry points for exported macros. Done means exported macros that invoke same-crate macros without the prefix are detected and the stated import scenarios no longer require users to import the invoked macro separately.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.