rust-lang / rust-lang/rust-clippy
New lint: comparing option to Some(true)
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Suggest replacing the expression x == Some(true) with x.unwrap_or(false). To me the second form better expresses what's going on: use the value in x otherwise default to false.
This is similar to the bool_comparison lint but I guess it could be more controversial. I'm OK if it's pedantic or restriction depending on what other people think.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing bool_comparison lint, which the issue identifies as similar, and trace how its suggestions are tested. Determine how a comparison with Some(true) should be recognized and whether the lint belongs in pedantic or restriction. Done means the proposed expression receives the intended unwrap_or(false) suggestion with appropriate coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100