rust-lang / rust-lang/rust-clippy
bad `match_ref_pats` suggestion.
Open
Nobody has claimed this yet.
C-bug
I-false-positive
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
In this line of this file of this commit, clippy says "you don't need to add & to all patterns", but because the & is actually changing the type of the binding, if you take off that & then the type going into png_u16 become wrong and the code doesn't compile.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/png.rs line 70 at the linked commit and reproduce the match_ref_pats suggestion. Check the suggested edit against the resulting type passed to png_u16 and verify that the code still compiles; done means the lint no longer recommends a change that breaks compilation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100