rust-lang / rust-lang/rust-clippy

dogfood: unicode-normalization takes 3 minutes to check

Open
#4,782 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

During the dogfood test ,clippy is run on itself to make sure its code has no clippy warnings.
During this process, clippy checks all the dependencies as well, however I think this may actually not be needed.

On my system, I can see that checking the unicode-normalization crate using clippy takes 2-3 minutes alone yet a simple "cargo check" of clippy seems to be much faster.

Perhaps we can somehow "cargo check" the dependencies in the dogfood test and only check the actual repo sourcecode using clippy for a decent dogfood speedup?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the dogfood test that runs Clippy on the repository and inspect how dependencies are handled. Compare the current dependency checking with the reported cargo check behavior, using unicode-normalization as the timing case. Done means the dogfood test avoids unnecessarily running Clippy on dependencies while still checking the repository source.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.