rust-lang / rust-lang/rust-clippy
Compare equal operands
Open
Nobody has claimed this yet.
C-enhancement
L-correctness
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Hi, there is a vulnerability fixed in https://github.com/sodiumoxide/sodiumoxide/pull/381. Would you please add a lint to somehow check whether lhs and rhs are equal in ==, !=, eq, ne, compare or a function name with a *cmp* in it?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the vulnerability fix in sodiumoxide/pull/381 and then inspect existing rust-clippy lint implementations and tests for comparable-expression checks. The work is done when a lint reliably identifies the requested equal-operand cases and its behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100