rust-lang / rust-lang/rust-clippy

FN in boxed_local lint

Open
#4,642 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-bug C-enhancement I-false-negative
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

This FN was introduced by the rustup #4628. To fix this major changes to the lint are probably necessary (https://github.com/rust-lang/rust-clippy/pull/4628#issuecomment-538574944).

A test for this FN already exists here:
https://github.com/rust-lang/rust-clippy/blob/e2393b09ac234aa19a2ffa368ef8d25ce645eaa3/tests/ui/escape_analysis.rs#L170-L174

Originally posted by @flip1995 in https://github.com/rust-lang/rust-clippy/pull/4628

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the boxed_local lint and the referenced test in tests/ui/escape_analysis.rs at lines 170-174. Review the rustup-related change in PR #4628 and its discussion to understand the false negative; done means the existing test no longer exposes the incorrect lint behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.