rust-lang / rust-lang/rust-clippy
Iterators: `.position()`+indexing instead of `.find()`
Open
Nobody has claimed this yet.
A-lint
E-medium
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
vec.iter().position(|x| x == foo)
.map(|idx| {
do_stuff_with(vec[idx])
});
This should be possible to integrate into the existing index-catching lints.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting rust-clippy’s existing index-catching lints and the linked commit example. Define tests for the iterator .position() followed by indexing pattern, then verify that the lint reports the intended case without false positives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100