rust-lang / rust-lang/rust-clippy

Suggest std::iter::{once, empty}

Open
#4,559 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint E-medium L-complexity L-suggestion
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

I don't know whether clippy is capable of doing this, but it would be nice to suggest std::iter::once() and std::iter::empty(), especially when things like vec![element].iter() (or similar) is used.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing rust-clippy's existing lint implementations and tests for patterns involving vec![element].iter() or similar iterator construction. Determine the intended cases for suggesting std::iter::once() and std::iter::empty(), then add coverage showing the suggestions and verify the relevant Clippy tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.