rust-lang / rust-lang/rust-clippy
Should //run-rustfix tests apply HasPlaceholders suggestions?
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Applying // run-rustfix to tests/ui/float_cmp_const.rs causes the HasPlaceholders suggestions contained within that lint to be applied.
Do we actually want this behavior? HasPlaceholders suggestions are things that should be applied manually imo.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tests/ui/float_cmp_const.rs and inspect how the // run-rustfix test flow handles HasPlaceholders suggestions. Determine whether applying those suggestions is intended; done means reaching and documenting a clear decision about the expected behavior and any test changes needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100