rust-lang / rust-lang/rust-clippy

Support for upcoming `param_attrs` feature

Open
#4,474 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-enhancement E-needs-test good first issue S-needs-discussion
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

param_attrs is likely to be stabilized in Rust 1.39

The param_attrs feature is going to allow lint attributes on function, method and closure parameters:

fn foo(
    a: i32,
    #[allow(unused_variables)] b: i32,
) {}

We should review how this feature ties in with our existing lints. Apparently it did not cause any toolstate breakage when it was merged.

Specifically, we should create a list of lints that could benefit from parameter attributes and then update those lints to make use of them (if that's even required).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Rust 1.39 param_attrs stabilization and implementation discussions, then review Clippy's existing lints for parameter-related cases. Done means identifying which lints benefit from parameter attributes and updating applicable lints if required, with validation for the resulting behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.