rust-lang / rust-lang/rust-clippy
clippy::drop_ref will trigger on `&mut T` as well as `&T`
Open
Nobody has claimed this yet.
C-bug
I-false-positive
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
the drop_ref lint will trigger on &mut T values being dropped, even though dropping them does have an effect.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the drop_ref lint implementation and its existing tests, then reproduce the reported behavior with a mutable reference (&mut T). Confirm the expected distinction between &mut T and &T, and use the lint's test suite to verify that the incorrect warning is gone without changing the reported behavior for shared references.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100