rust-lang / rust-lang/rust-clippy
Extract commonly used visitors to utils
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Both #3427 and #4386 implement a Visitor that walks an expression and searches for a return. This should be de-duplicated.
Maybe there are other Visitors in the Clippy code base, that also do similar things and can be extracted to utils.
Originally posted by @mikerite in https://github.com/rust-lang/rust-clippy/pull/4386#issuecomment-522407926
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the Visitor implementations introduced in #3427 and #4386, then search the Clippy codebase for other similar visitors. Extract the shared visitor into utils and update the duplicated users, with the relevant lint behavior still covered by the existing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100