rust-lang / rust-lang/rust-clippy
Restrict let_and_return if the let binding is large
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Currently, the let_and_return lint is always triggered. I have quite a lot of code which looks like:
let something = match something_else {
Variant1 => { /* something */},
...
Variant_some_very_large_number => { /* whatever */ }
};
something
Here, I believe it is a lot clearer to explicitly have the let binding, since you may have to scroll quite far to see that there's no semi-colon at the end of the match block for it to be obvious that it's the return expression. I don't know what a suitable size threshold would be, or even if it's possible to reasonably make restrictions based on that.
Of course, I'm open to other ways of writing code blocks like this which would also solve the issue!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the let_and_return lint entry point and inspect how it identifies the return expression. Review the discussion around a size threshold or alternative rule, then determine whether the large match-binding case can be distinguished reliably; done means the behavior and threshold are covered by focused lint tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100