rust-lang / rust-lang/rust-clippy

Lint types the Deref to slice with no inherent as_ptr/as_mut

Open
#4,184 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

See https://twitter.com/llogiq/status/1136868526776573952?s=09

The problem is that creating a slice asserts that the memory region is valid and not (mutably) borrowed, which may cause UB. An inherent method can avoid that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or lint name is provided. Start by reproducing the reported behavior with cargo clippy and identify the lint handling a Deref to a slice without inherent as_ptr/as_mut methods. Done means the lint no longer recommends or accepts the unsafe slice-based behavior described in the issue, with coverage for the reported case.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.