rust-lang / rust-lang/rust-clippy
Does not detect redundant use of collect + iter + map
Open
Nobody has claimed this yet.
A-lint
L-complexity
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
There might be reasons this is not always the case, however, it seems like a situation when I was being far too verbose and an opportunity for clippy to let me know. Here is the verbose version of the code:
(1..=64)
.collect::<Vec<_>>()
.iter()
.map(|&sq| square(sq))
.sum()
Here is the pithy version of the code:
(1..=64).map(square).sum()
- E
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by searching rust-clippy for existing lints that inspect iterator chains involving collect, iter, and map, then compare their testing patterns with the two examples in this issue. Done means the redundant chain is detected and a suggestion for the direct map-and-sum form is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100