rust-lang / rust-lang/rust-clippy
New lint: wildcard pattern in let
Open
Nobody has claimed this yet.
A-lint
good first issue
L-restriction
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
I think there should be a warning about the wildcard pattern in let.
I can't imagine any situation where this makes sense, and there are cases where it's a mistake caused by taking _ for identifier though it's not.
Wrong:
{
let _ = my scope guard or whatever
// dropped right away
do stuff
}
Correct:
{
let _g = my scope guard or whatever
do stuff
// dropped at the end of the scope
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the issue's two Rust examples and investigate how Clippy defines and tests lints for suspicious let patterns. The change is complete when the wildcard pattern in the incorrect example produces a warning while the named guard in the correct example does not; no source file or test path is specified here.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100