rust-lang / rust-lang/rust-clippy
Audit macro checks and see if they can ignore desugarings
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
https://github.com/rust-lang/rust-clippy/pull/4080 made all macro checks ignore desugarings. But sometimes this ends up breaking things, like https://github.com/rust-lang/rust-clippy/issues/4081, where the ? operator is creating an into() conversion that we catch.
https://github.com/rust-lang/rust-clippy/pull/4082 moves almost all the macro checks back to checking for desugarings. We should audit these -- in most cases the macro is not checking anything that can potentially be tripped by code from a desugaring.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the behavior changed in pull requests 4080 and 4082, then read issue 4081 for the desugaring regression. Audit the macro checks affected by that change and determine which can safely ignore desugarings. Done means each affected check has a documented decision and the necessary follow-up is identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100