rust-lang / rust-lang/rust-clippy
warn if println() statements found in functions annotated as #[bench]
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
This can impact performance quite a lot in otherwise fast functions (have seen 20-30%) and is probably a left over from "let's make this #[test] a #[bench]mark as well" conversions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named in the issue. Start by locating the lint implementations and tests for #[bench] functions and println! handling in rust-clippy, then determine how a warning should be emitted only for println! statements inside benchmarks. Done means the intended benchmark case is covered by a test and the warning behavior is verified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100