rust-lang / rust-lang/rust-clippy
Lint `static mut FOO: T` where `T` has a safe counterpart
Open
Nobody has claimed this yet.
A-lint
good first issue
L-correctness
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
There is no reason to ever write static mut FOO: u32. Instead one should use static FOO: AtomicU32 which does the same thing, is just as efficient and requires no unsafe code.
We should lint this for at least
u8,u16,u32,u64i8,i16,i32,i64isize,usizebool*mut T
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Clippy's lint implementation and test conventions for type-based lints. Cover the scalar types and mutable pointer type listed in the issue, and add coverage showing that the lint recognizes their safe counterparts. Done means the requested patterns are diagnosed consistently without requiring unsafe code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100