rust-lang / rust-lang/rust-clippy
new lint: sort collection after checking it is empty
Open
Nobody has claimed this yet.
A-lint
L-perf
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
let mut v: Vec<_> = ...
v.sort(); // move into condition
if v.is_empty() {
bla();
} else {
foo(&v);
}
There is no need to sort v if we know that it is empty, could we suggest sinking the sort() into the else branch?
if v.is_empty() {
bla();
} else {
v.sort(); // moved here
foo(&v);
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No implementation file or test is named. Start by reproducing the Rust example and tracing how rust-clippy defines and tests lints; done means the lint recognizes the pre-check sort pattern and suggests moving sort into the non-empty branch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100