rust-lang / rust-lang/rust-clippy
wrong_self_convention fails for libstd RawEntryBuilderMut::from_key
Open
Nobody has claimed this yet.
C-bug
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
libstd RawEntryBuilderMut::from_key is a builder, which takes self as first argument and the key to use as a second argument. This seems ok, but wrong_self_convention lints it.
https://doc.rust-lang.org/std/collections/hash_map/struct.RawEntryBuilderMut.html#method.from_key
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the wrong_self_convention lint and reproduce its report for libstd's RawEntryBuilderMut::from_key using the linked standard-library documentation. Read the lint's existing tests and behavior around builder methods; done means this valid method is no longer incorrectly reported while the lint's intended checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100