rust-lang / rust-lang/rust-clippy

Enum where all variants have the same variable(s)

Open
#368 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

S-needs-discussion
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

enum SomeEnum {
    A(i32),
    B(i32),
    C(i32)
}

should really be

enum SomeEnum {
    A,
    B,
    C
}

struct SomeStruct {
    variant: SomeEnum,
    data: i32
}

in most cases.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue provides Rust enum examples but names no implementation files, tests, or entry points. Start by locating how rust-clippy defines and tests enum-related lints, then establish whether this pattern should produce a diagnostic and what an appropriate suggestion would need to cover.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.