rust-lang / rust-lang/rust-clippy
redundant_closure should be in the Perf group
Open
Nobody has claimed this yet.
A-category
S-needs-discussion
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
The redundant_closure lint should be in the Perf group. All those closures take code space. The optimizer can't combine closures, even if they're identical. (Perhaps it can for Option::map; I haven't checked. But definitely for Future::map it cannot).
> cargo +nightly clippy -V
clippy 0.0.212 (481f7880 2018-10-30)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the redundant_closure lint and the definitions of the Perf group in rust-clippy. Check the lint's current grouping and relevant tests, then verify that the lint is reported under Perf without changing its behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- performance, tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100