rust-lang / rust-lang/rust-clippy
new lint: variable scope that can be reduced
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
inspired by cppcheck
It could warn about code like this:
fn do_something(is_true: bool, word: String) -> String {
let mut s = String::from("hello world");
if is_true {
s.push_str(&word);
s
} else {
word
}
}
where the scope of s can be savely reduced to span across the true branch of the if:
fn do_something(is_true: bool, word: String) -> String {
if is_true {
let mut s = String::from("hello world");
s.push_str(&word);
s
} else {
word
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No implementation file, test, or entry point is named. Start from the two Rust examples and identify the Clippy lint location and test convention for this pattern; done means the reduced-scope case is warned about while the alternative branch remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100