rust-lang / rust-lang/rust-clippy
FR: redundant_field_names should distinguish between all and some fields matching
Open
@Jarcho is already working on this.
Since Nov 8, 2025.
C-enhancement
good first issue
L-style
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
redundant_field_names fires on any field being a match. This impairs readability in cases like this:
let thingy = Thingy {
calc: big + calculation,
redundant: redundant,
other: stuff.into(),
};
As you can see, if you apply the suggestion, you end up with a weird line that is different from the rest. I suggest that the lint be split such that it distinguishes between "all fields are redundant" and "some fields are redundant".
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.