rust-lang / rust-lang/rust-clippy

new lint: getting last element of path via iter().last()

Open
#3,417 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

In my code I found something awful like this:

        let name = path
            .to_str()
            .unwrap()
            .split('/')
            .last()
            .unwrap()
            .to_string();

to get the last element of a path.

This could be rewritten without split

    let last = path.into_iter().last().unwrap().to_str().unwrap().to_owned();

but most idiomatic is probably

let last = path.file_name().unwrap().to_str().unwrap().to_string();

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Rust examples in the issue and locate Clippy’s existing lint implementations and UI-test entry points. Determine the intended matching and diagnostic behavior for the split or iter().last() path pattern, then add coverage for the proposed path-based alternative; done when the relevant Clippy tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.