rust-lang / rust-lang/rust-clippy
new lint: pointless match
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
I wonder if it would make sense to lint against matches that match on and return the same values, like this
fn main() {
let x = 4;
let _ = match x {
1 => 1,
4 => 4,
x => x,
};
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing existing rust-clippy lint implementations and their tests for match simplifications. Add coverage for the example in the issue and define a diagnostic for matches whose arms return the values they match; done means the lint reliably identifies that pattern without false positives.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100