rust-lang / rust-lang/rust-clippy

Lint for `match` in match arm predicate

Open
#3,329 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

In the category of Style, having a lint against code where the predicate contains a match expression.

Trivial example:

match () {
  _ if match () { _ => true } => {}
}

The rationale for this is that either the matched value should be a part of the outer match or that it's just complex code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Rust example in the issue and inspect existing Clippy style lints for their implementation and test conventions. The work is complete when Clippy reports the proposed lint for a match expression used in a match-arm predicate, with tests covering the example and acceptable cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.