rust-lang / rust-lang/rust-clippy
New lint: suggest `is_ok()` when using wild pattern in both Ok and Err
Open
Nobody has claimed this yet.
C-enhancement
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
As @killercup mentioned in https://github.com/rust-lang-nursery/rust-clippy/pull/3281#discussion_r223504940 , we can have a new lint to suggest developers to change like following
// As is
match Ok::<i32, i32>(42) {
Ok(_) => $1,
Err(_) => $2,
};
// To be
if Ok::<i32, i32>(42).is_ok() { $1 } else { $2 }
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked rust-clippy pull request discussion and the Rust match example in the issue. Determine how an existing Clippy lint recognizes equivalent match patterns, then add coverage showing the suggested is_ok() form for matching both Ok(_) and Err(_); done means the lint emits that suggestion correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100