rust-lang / rust-lang/rust-clippy
Lint suggestion - elide pointless match
Open
Nobody has claimed this yet.
A-lint
L-unnecessary
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
I noticed some code like this that I had written not long ago:
let meta = if let Some(meta) = data_store.get_meta(reference.key) {
Some(meta)
} else {
None
};
This can of course be simplified to
let meta = data_store.get_meta(reference.key);
There may be value in a clippy lint to catch cases like this, as it already warns on a lot of redundant code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue provides Rust examples but names no source files or tests. Start by locating existing Clippy lints for redundant code or match simplification, then define the covered cases and add tests showing the if-let/else None form is reported while the direct get_meta form is accepted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100