rust-lang / rust-lang/rust-clippy

DeMorgan for `all`/`any` in attrs

Open
#3,176 6 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint L-style S-blocked T-AST T-macros
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

We should lint attributes of the style #[cfg(all(not(_), not(_), ..))] and #[cfg(any(not(_), not(_), ..))] and suggest #[cfg(not(any(_, _, ..))] and #[cfg(not(all(_, _, ..))], respectively. Bonus points for further simplification.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named in the issue. Start by locating Clippy's existing attribute-related lint implementation and tests, then verify the requested DeMorgan suggestions for cfg(all(...)) and cfg(any(...)) patterns, including any supported further simplification.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.