rust-lang / rust-lang/rust-clippy
Lint #[cfg(any(_))] / #[cfg(all(_))] attributes
Open
Nobody has claimed this yet.
A-lint
L-style
T-AST
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
We should lint cfg(any(one))/cfg(all(one)), because those any/alls don't pull their weight and may confuse readers. (The same goes for cfg_attr and cfg!() macros, obviously).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Clippy's existing lint implementations and tests for cfg attributes and cfg-related macros. Define the expected diagnostics for single-item any/all uses in cfg, cfg_attr, and cfg!(), then add coverage showing that redundant wrappers are reported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100