rust-lang / rust-lang/rust-clippy

Lint when trait contains method with same name as method from trait heirachy

Open
#3,117 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

If a trait declares a method that has the same name as a method from its trait hierarchy, then both methods can only be called via UFCS. It's also confusing. As such, clippy should lint against it.

trait Base {
     fn method() {}
}

trait Subtrait : Base {
    //~ warning: method has same name as Base::method.
    fn method() {}
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating existing Clippy lint implementations and tests for trait methods, then run the relevant Clippy test suite; done means the example produces a warning when a subtrait method repeats a method name from its trait hierarchy.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.