rust-lang / rust-lang/rust-clippy
Suggestions for toplevel_ref_arg should not move `mut` to the right-hand side
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
When clippy sees code like this:
let ref mut foo = false;
It'll suggest changing it to this:
let foo = &mut false;
However, while ref on the left-hand side is not idiomatic Rust, mut on the left-hand side is, and often the code would look much clearer if written as:
let mut foo = false;
(With corresponding changes to code using foo.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the toplevel_ref_arg lint and its suggestion tests. Compare the current recommendation for let ref mut foo = false; with the intended let mut foo = false; form, including any required changes to uses of foo, and update the tests to show the desired result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100