rust-lang / rust-lang/rust-clippy
new lint: use string.push_str(&str) instead of string.push_str(&String) for literals
Open
@blyxyas is already working on this.
Since Sep 16, 2026.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
let mut s = String::from("hello");
s.push_str(&String::from(" world")); // also check for "...".into() etc
should just be
let mut s = String::form("hello");
s.push_str(" world");
The second example generates less instructions:
https://rust.godbolt.org/z/FO60r-
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.