rust-lang / rust-lang/rust-clippy
Lint calls to `#[no_mangle]` functions that don't have `#[inline(never)]`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Noticed when trying to debug rustc. The rust_panic function is inlined sometimes which makes it impossible to set a breakpoint on it.
If the #[no_mangle] function is just for C and never called from Rust it should be fine (though not sure how llvm copes on that and maybe still inlines it, but that seems ok, since you might even have wanted that behaviour).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the rust_panic function in src/libstd/panicking.rs, the example named in the issue, and examine how its #[no_mangle] and inlining affect debugging. Done means Clippy identifies applicable #[no_mangle] functions that lack #[inline(never)] and accounts for the stated C-only case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100