rust-lang / rust-lang/rust-clippy
Prefer `ptr.add([usize])` over `ptr.offset([usize] as isize)`
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Checklist
- Prefer
ptr.add([usize])overptr.offset([usize] as isize) - Prefer
ptr.sub([usize])overptr.offset(-([usize] as isize)) - Prefer
ptr.wrapping_add([usize])overptr.wrapping_offset([usize] as isize) - Prefer
ptr.wrapping_sub([usize])overptr.wrapping_offset(-([usize] as isize))
API links
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Rust pointer API links in the issue and locate the existing Clippy lint handling ptr.offset and wrapping_offset. Implement the two unchecked sub and wrapping_sub cases, while preserving the already checked add and wrapping_add cases. Done means the remaining checklist items are covered by the lint behavior and its tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100